Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to strict mode #1848

Merged
merged 61 commits into from Mar 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
367448f
Fixed strict violations
FabianGosebrink Sep 26, 2023
c579664
Fixed more strict issues
FabianGosebrink Sep 26, 2023
4143e24
Fixed more strict issues
FabianGosebrink Sep 26, 2023
31a8c62
Solved more strict issues
FabianGosebrink Sep 26, 2023
90113ca
MOre strict issues
FabianGosebrink Sep 26, 2023
6bd1b7b
more issues fixed
FabianGosebrink Sep 26, 2023
265a1d0
Fixed more strict mode issues
FabianGosebrink Sep 28, 2023
b638a34
More strict issues
FabianGosebrink Sep 28, 2023
3f8c44b
Fixed linting
FabianGosebrink Oct 2, 2023
34e3540
Merge branch 'fabiangosebrink-fix/strict-mode-1' of https://github.co…
FabianGosebrink Oct 3, 2023
5452f5a
added more null checks
FabianGosebrink Oct 15, 2023
148ed4a
Foxed more errors
FabianGosebrink Oct 15, 2023
ea41b50
added strict mode
FabianGosebrink Oct 15, 2023
f1d1427
Update code formatting and type annotations
FabianGosebrink Jan 3, 2024
075cfe6
Fix login service and flows service callback return types
FabianGosebrink Jan 4, 2024
a8cfdcb
Merge remote-tracking branch 'origin/main' into fabiangosebrink-fix/s…
FabianGosebrink Jan 4, 2024
b1f73b5
Fix various issues and improve code
FabianGosebrink Jan 4, 2024
f161de8
Add LoginResponse import and update checkAuth return value
FabianGosebrink Jan 4, 2024
ba4aa11
Fix null reference errors and update dependencies
FabianGosebrink Jan 4, 2024
a657b7a
Fix type annotations and initialize variables
FabianGosebrink Jan 4, 2024
f9b08d5
Update configuration and callback context objects
FabianGosebrink Jan 4, 2024
bdc7bff
Fix test assertions and parameter in popup service
FabianGosebrink Jan 4, 2024
33d69fa
Fix unit test failures in auth-state and url services
FabianGosebrink Jan 4, 2024
80829e7
Refactor URL service to simplify code
FabianGosebrink Jan 4, 2024
80c876f
Fix CheckAuthService configuration issue
FabianGosebrink Jan 26, 2024
d9d4891
Fix unit test failures and code cleanup
FabianGosebrink Jan 26, 2024
9deb5d0
Fix config validation and callback handling in unit tests
FabianGosebrink Jan 27, 2024
ac134c1
Fix validation test and update popup service test
FabianGosebrink Jan 27, 2024
4e19c7d
Fix CheckAuthService test cases
FabianGosebrink Jan 27, 2024
c4b4611
Fix CheckAuthService test cases
FabianGosebrink Jan 27, 2024
cdece08
Fix getCurrentUrl() in CheckAuthService.spec.ts
FabianGosebrink Jan 27, 2024
653a4ba
Fix existingIdToken assignment and update test expectation
FabianGosebrink Jan 27, 2024
d3f9d96
Fix callback error handling and update configurations
FabianGosebrink Jan 27, 2024
50d68c7
Fix configuration error in LoginService
FabianGosebrink Jan 28, 2024
873979c
Merge remote-tracking branch 'origin/main' into fabiangosebrink-fix/s…
FabianGosebrink Feb 4, 2024
83becb8
Merge branch 'fabiangosebrink-fix/strict-mode-1' of https://github.co…
FabianGosebrink Feb 28, 2024
6deb8bc
Merge remote-tracking branch 'origin/main' into fabiangosebrink-fix/s…
FabianGosebrink Mar 17, 2024
e90ce9e
Fix login service login function signature
FabianGosebrink Mar 17, 2024
282ba95
Fix current URL service and URL service unit tests
FabianGosebrink Mar 17, 2024
f7dcaac
Add AuthConfig unit test
FabianGosebrink Mar 17, 2024
487b995
Refactor pre-commit hooks and fix linting issues
FabianGosebrink Mar 17, 2024
8e6f6e1
Refactor code to remove redundant assignments and imports
FabianGosebrink Mar 18, 2024
6a9bc54
Refactor authentication code in home and navigation components
FabianGosebrink Mar 18, 2024
1bf7ea6
Refactor authentication code in home and navigation components
FabianGosebrink Mar 18, 2024
0f1e04b
Update template bindings in multiple components
FabianGosebrink Mar 18, 2024
549676e
Refactor authentication code in HomeComponent and NavigationComponent
FabianGosebrink Mar 18, 2024
89af487
Refactor Angular component imports and remove unused lifecycle hooks
FabianGosebrink Mar 18, 2024
b02b893
Fix ngOnInit method signature in app components
FabianGosebrink Mar 18, 2024
8b45cf2
Update linting command and fix method signatures
FabianGosebrink Mar 18, 2024
8c94390
Exclude spec.ts files from compilation
FabianGosebrink Mar 18, 2024
af12588
Add tsconfigRootDir to ESLint configuration
FabianGosebrink Mar 18, 2024
4a97bcb
Update linting command for library
FabianGosebrink Mar 18, 2024
d1b3fc0
Update configuration service in unit tests
FabianGosebrink Mar 18, 2024
6f31e0a
Update service providers in unit tests
FabianGosebrink Mar 18, 2024
d0bce96
Update service providers in unit tests
FabianGosebrink Mar 18, 2024
e22aee6
Refactor test dependencies
FabianGosebrink Mar 18, 2024
f65cad2
Fix dependency injection issue in data and http base services
FabianGosebrink Mar 18, 2024
b3a5089
Update stsCallback$ return type to Observable<void>
FabianGosebrink Mar 18, 2024
6b19d33
Fix spy return value in stsCallback$ test
FabianGosebrink Mar 18, 2024
f2ceaef
Update projects/angular-auth-oidc-client/src/lib/callback/interval.se…
FabianGosebrink Mar 21, 2024
d2da01e
Fix interval service injection and use of setInterval
FabianGosebrink Mar 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions .eslintrc.json
Expand Up @@ -6,7 +6,8 @@
"files": ["*.ts"],
"parserOptions": {
"project": ["tsconfig.json"],
"createDefaultProgram": true
"createDefaultProgram": true,
"tsconfigRootDir": "./"
},
"extends": [
"plugin:@angular-eslint/recommended",
Expand All @@ -21,7 +22,6 @@
"format": ["PascalCase"]
}
],
"newline-before-return": "error",
"max-len": "off",
"no-useless-constructor": "off",
"lines-between-class-members": ["error", "always"],
Expand All @@ -36,12 +36,22 @@
"no-empty": ["error"],
"@typescript-eslint/no-empty-function": ["error"],
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": ["error"],
"@typescript-eslint/ban-types": ["error"],
"no-useless-escape": ["error"],
"no-prototype-builtins": ["error"],
"prefer-spread": ["error"],
"@typescript-eslint/no-explicit-any": "off"
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/typedef": ["error"],
"@typescript-eslint/explicit-function-return-type": ["error"],
"newline-before-return": ["error"],
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"
}
]
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Installing Dependencies
run: npm ci

- name: Linting Frontend
- name: Linting Library
run: npm run lint-lib

- name: Testing Frontend
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -50,3 +50,4 @@ Thumbs.db
debug.log

/.husky
/.nx