Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Query parameter hijacking #1935

Open
erichjsonfosse opened this issue May 8, 2024 · 1 comment
Open

[Bug]: Query parameter hijacking #1935

erichjsonfosse opened this issue May 8, 2024 · 1 comment

Comments

@erichjsonfosse
Copy link
Contributor

Version

At least 16 and 17

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

The `isCallbackFromSts` only checks for one of the query parameters in the `CALLBACK_PARAMS_TO_CHECK` array, effectively hijacking these parameters for every route in the application.

Steps to reproduce the behavior

Add any of the `CALLBACK_PARAMS_TO_CHECK` (['code', 'state', 'token', 'id_token']) to the application URL, and the `isCallbackFromSts` method will return true.

A clear and concise description of what you expected to happen.

I would expect the `isCallbackFromSts` to take the redirect URI into consideration.

Additional context

No response

@FabianGosebrink
Copy link
Collaborator

Related to #1912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants