Merge pull request #1751 from damienbod/bugfix/id_token_expire_check

Bugfix id token expire check
damienbod · May 5, 2023 · f2ff476 · f2ff476
2 parents 213a818 + bf1cc7f
commit f2ff476
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## Angular Lib for OpenID Connect/OAuth2 Changelog
 
+### 2023-05-05 15.0.5
+
+- Bugfix id token expire check
+  - [PR](https://github.com/damienbod/angular-auth-oidc-client/pull/1751)
+
 ### 2023-04-15 15.0.4
 
 - isCurrentlyInPopup will check for opener and session storage 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
   "bugs": {
     "url": "https://github.com/damienbod/angular-auth-oidc-client/issues"
   },
-  "version": "15.0.4",
+  "version": "15.0.5",
   "scripts": {
     "ng": "ng",
     "build": "npm run build-lib",

diff --git a/projects/angular-auth-oidc-client/package.json b/projects/angular-auth-oidc-client/package.json
@@ -36,7 +36,7 @@
     "authorization"
   ],
   "license": "MIT",
-  "version": "15.0.4",
+  "version": "15.0.5",
   "description": "Angular Lib for OpenID Connect & OAuth2",
   "schematics": "./schematics/collection.json",
   "ng-add": {

diff --git a/projects/angular-auth-oidc-client/src/lib/callback/periodically-token-check.service.ts b/projects/angular-auth-oidc-client/src/lib/callback/periodically-token-check.service.ts
@@ -169,6 +169,9 @@ export class PeriodicallyTokenCheckService {
       return false;
     }
 
-    return this.authStateService.hasAccessTokenExpiredIfExpiryExists(config);
+    const idTokenExpired = this.authStateService.hasIdTokenExpiredAndRenewCheckIsEnabled(config);
+    const accessTokenExpired = this.authStateService.hasAccessTokenExpiredIfExpiryExists(config);
+
+    return idTokenExpired || accessTokenExpired;
   }
 }
diff --git a/projects/schematics/package.json b/projects/schematics/package.json
@@ -1,6 +1,6 @@
 {
   "name": "schematics",
-  "version": "15.0.4",
+  "version": "15.0.5",
   "description": "A schematic for the Angular Lib for OpenID Connect & OAuth2",
   "scripts": {
     "build": "tsc -p tsconfig.json",

diff --git a/projects/schematics/src/ng-add/actions/add-dependencies.ts b/projects/schematics/src/ng-add/actions/add-dependencies.ts
@@ -5,7 +5,7 @@ import { NgAddOptions } from '../models/ng-add-options';
 const dependenciesToAdd: any[] = [
   {
     name: 'angular-auth-oidc-client',
-    version: '15.0.4',
+    version: '15.0.5',
   },
 ];