Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber reporting - New Generation UI #923

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Cucumber reporting - New Generation UI #923

wants to merge 39 commits into from

Conversation

fslev
Copy link

@fslev fslev commented Apr 12, 2020

It is quite too early for this pull request to be approved, since it contains code that still needs some cleanup. It doesn't need to be approved at all: it's just a UI demo.
The idea behind is that I want you to take a look on the new revamped UI version of cucumber-reporting. Basically, I've tried to make it cleaner (Each passed step has now a white background. Having other background color it can distract you from the text within). Also added some contrast style where important sections are displayed, thus making the UI also more memorable.
You can take a short look by running the LiveDemoTest

# Conflicts:
#	pom.xml
# Conflicts:
#	pom.xml
# Conflicts:
#	pom.xml
…cucumber-reporting

[maven-release-plugin]  copy for tag cucumber-reporting-4.11.1

# Conflicts:
#	pom.xml
#	src/main/java/net/masterthought/cucumber/json/deserializers/EmbeddingDeserializer.java
#	src/test/resources/json/sample.json
# Conflicts:
#	pom.xml
#	src/main/java/net/masterthought/cucumber/Configuration.java
#	src/main/java/net/masterthought/cucumber/ReportParser.java
#	src/main/java/net/masterthought/cucumber/ReportResult.java
#	src/main/java/net/masterthought/cucumber/json/Element.java
#	src/main/java/net/masterthought/cucumber/util/StepNameFormatter.java
#	src/test/java/net/masterthought/cucumber/ReportGenerator.java
#	src/test/java/net/masterthought/cucumber/ReportParserTest.java
#	src/test/java/net/masterthought/cucumber/generators/integrations/FailuresOverviewPageIntegrationTest.java
#	src/test/java/net/masterthought/cucumber/generators/integrations/FeaturesOverviewPageIntegrationTest.java
#	src/test/java/net/masterthought/cucumber/generators/integrations/PageIntegrationTest.java
#	src/test/java/net/masterthought/cucumber/generators/integrations/StepsOverviewPageIntegrationTest.java
#	src/test/resources/json/sample.json
[maven-release-plugin]  copy for tag cucumber-reporting-5.1.1

# Conflicts:
#	pom.xml
#	src/main/java/net/masterthought/cucumber/generators/AbstractPage.java
#	src/main/java/net/masterthought/cucumber/json/Feature.java
#	src/main/resources/templates/macros/report/statsTable.vm
#	src/test/java/net/masterthought/cucumber/generators/AbstractPageTest.java
#	src/test/java/net/masterthought/cucumber/generators/ErrorPageTest.java
#	src/test/java/net/masterthought/cucumber/generators/FailuresOverviewPageTest.java
#	src/test/java/net/masterthought/cucumber/generators/FeaturesOverviewPageTest.java
#	src/test/java/net/masterthought/cucumber/generators/TagsOverviewPageTest.java
#	src/test/java/net/masterthought/cucumber/generators/TrendsOverviewPageTest.java
Merge tag 'cucumber-reporting-5.1.1'
[maven-release-plugin]  copy for tag cucumber-reporting-5.1.1
@damianszczepanik
Copy link
Owner

Nice, probably more modern but less compact what IMO is disadvantage

@fslev
Copy link
Author

fslev commented Apr 12, 2020

Indeed. Some compact related styles were sacrificed. Compact is good for small screens. However, in a demo session, on a projector, it's quite hard to follow all the details. Pros and cons. Thus a compact feature toggle could be in place at some point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants