Update list of reveal.js config options #590
Conversation
[These lines](https://github.com/damianavila/RISE/blob/ebfcb5760823787e632b4a0c19681829474d1710/classic/rise/static/main.js#L539-L540) suggest that more options are actually passed through. I took the descriptions from the reveal documentation. (Note that the website is currently down, so I just looked through the [src](https://github.com/reveal/revealjs.com/blob/master/src/config.md).)
|
@moble, thanks for the PR but even when some other options are passthrough, modifying some of them could be problematic (https://github.com/damianavila/RISE/blob/master/classic/rise/static/main.js#L110), this is why we do not advertise them. @parmentelat, maybe we need to prevent passing through some of these options... thoughts? |
|
hiya everythone well, given that, as the Python motto has it, we're all consenting adults here, I'd rather leaver this open, but indeed a few words of warning about the possible negative effects of tweaking them could be quite helpful |
I would be OK with that!
Me too 😉 maybe @moble has some words for us! |
I'm afraid I'm more lost than ever, now. I would appreciate some direction on which options will/should work. |
I guess we are essentially asking you to add to your PR some note that warns the user that things could be wrong if they tweak those additional parameters (the ones you added). |
parmentelat
force-pushed
the
master
branch
2 times, most recently
from
5e2531e
to
6d81041
Compare
These lines suggest that more options are actually passed through. I took the descriptions from the reveal documentation. (Note that the website is currently down, so I just looked through the src.)