Proposal : alternative pom to build jre with remote debugging capabilites #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I'm gonna try to remove the duplication. I don't want to maintain two almost identical pom files. I thought a "dev" profile made sense. Perhaps the new variable could be called |
Add an alternative JRE pom file to build it with jdk.jdwp.agent included, allowing to do remote debugging on it. Modified the Makefile to only use this file when a make is called with `make DEV=1 ...`.
|
@NPavie I updated the branch. Can you check if it still works for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first i was thinking of a "dev" profile in the build-jre pom, but it seemed easier to have a copied build file for it with just the new module added.
This is what i did for this proposal:
(like
make <anytarget> DEV=1, else it remains the same)It works on Windows with the embedded make.exe, so I expect it to work on MacOS and Linux too.
Having this option would help in debugging the pipeline while testing it through the word addin or the pipeline app.
(Note: both apps are already checking for the presence of the jdk.jdwp.agent module in the included jre in debug mode to allow this connection)