Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/methods to trigger viewable impression trackers #454

Merged
merged 16 commits into from
Aug 23, 2023
Merged

Enhancement/methods to trigger viewable impression trackers #454

merged 16 commits into from
Aug 23, 2023

Conversation

Rapha0511
Copy link
Contributor

@Rapha0511 Rapha0511 commented Aug 22, 2023 •
edited by ZacharieTFR

Description

Adding 3 public methods to track viewableImpression

  • trackViewableImpression() to report all <Viewable> URI
  • trackNotViewableImpression() to report all <notViewable> URI
  • trackUndeterminedImpression() to report all <ViewableUndetermined> URI

Issue

The vastTracker did not provide any methods to track viewableImpression node

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

ZacharieTFR
ZacharieTFR requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ZacharieTFR ZacharieTFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing ! I left few comments

docs/api/vast-tracker.md Outdated Show resolved Hide resolved
docs/api/vast-tracker.md Outdated Show resolved Hide resolved
docs/api/vast-tracker.md Outdated Show resolved Hide resolved
spec/samples/inline_trackers.js Outdated Show resolved Hide resolved
src/parser/ad_parser.js Outdated Show resolved Hide resolved
@ZacharieTFR ZacharieTFR merged commit 2a6e9ae into master Aug 23, 2023
1 check passed
@ZacharieTFR ZacharieTFR deleted the enhancement/methods-to-trigger-viewableImpression-trackers branch August 23, 2023 14:44
@ZacharieTFR ZacharieTFR mentioned this pull request Aug 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacharieTFR ZacharieTFR ZacharieTFR approved these changes

Assignees

@Rapha0511 Rapha0511

Labels
breaking-change documentation enhancement feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rapha0511 @ZacharieTFR