Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep 4.X branch updated with master changes #418

Merged
merged 50 commits into from Feb 10, 2022
Merged

Keep 4.X branch updated with master changes #418

merged 50 commits into from Feb 10, 2022

Conversation

ZacharieTFR
Copy link
Contributor

@ZacharieTFR ZacharieTFR commented Jan 21, 2022 •
edited

Description

Master branch was updated with 3.X changes but as we have 4.X branch dedicated to breaking changes we must keep it up to date with master changes.

Issue

#409

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

PaulineMDaily and others added 30 commits December 8, 2020 17:23
@PaulineMDaily
updated doc and added a deprecation on errorWithCode
4095326
@PaulineMDaily
[enhancement] modified wording for deprecation
2137a42
@PaulineMDaily
modified example and added link of errorWithCode
bcf5461
@PaulineMDaily
added documentation on the error method about ERRORCODE macro
c51f0cb
@PaulineMDaily
modified wording on documentation on errorWithCode
06db17a
@PaulineMDaily
updated security issues on vast-client
a76b041
@clementFrancon
[parser] Add bitrate estimation from VAST requests
10a01a0
@PaulineMDaily
add package.json lock (updateSecurityIssues)
edb1909
@clementFrancon
[parser] Make bitrate estimation a singleton small optimizations on t…
dfe21b5 
…he computed value
@clementFrancon
[parser] Change bitrate unit from bps to kbps
0138407
@clementFrancon
[parser][docs] improve doc about estimated bitrate
520821f
@PaulineMDaily
fix problem with adVerification nodes merging (updateMergingAdVerific…
501f009 
…ation)
@PaulineMDaily
add condition if vast < 4.1
d86e96f
@PaulineMDaily
add UT + typo
9f1d9dd
@PaulineMDaily
updated new security issue
8165643
@PaulineMDaily
update doc + link
4bbae74
@PaulineMDaily
fixed typo + naming
220e7fc
@ZacharieTFR
Merge pull request #402 from dailymotion/bitrate-suggestion
7b3d75c 
[parser] Add bitrate estimation from VAST requests
@ZacharieTFR
Merge pull request #401 from dailymotion/updateSecurityIssues
40b51e1 
Updated dependencies because of security issues on vast-client-js
@PaulineMDaily
delete condition
d85daf2
@ZacharieTFR
Merge pull request #403 from dailymotion/updateMergingAdVerification
f9a3407 
[parser] Merge correctly adVerification from extension and from its own node
@PaulineMDaily
Bundle release 3.2.0
dfa9105
@PaulineMDaily
3.2.0
d5b72fa
@PaulineMDaily
prettier files
2cefac6
@PaulineMDaily
[doc] vast-client is now scoped package @org/name
befb016
@PaulineMDaily
update package.json with scoped name
eef557b
@PaulineMDaily
Merge pull request #407 from dailymotion/prettierUpdate
1809885 
Prettier 2.0 for VAST-Client
@PaulineMDaily
Merge pull request #408 from dailymotion/updateReadMe
862c103 
[doc]  Update doc because Vast-client will be a NPM scoped package @dailymotion/vast-client
@PaulineMDaily
Merge pull request #411 from dailymotion/3.X
1c8ee18 
Update master branch to 3.X to benefit latest fixes
@PaulineMDaily
3.3.0
4ddaa1a
@ZacharieTFR ZacharieTFR self-assigned this Jan 21, 2022
@ZacharieTFR ZacharieTFR added the wip Work in progress label Jan 21, 2022
ZacharieTFR and others added 18 commits January 27, 2022 16:21
@ZacharieTFR
Merge pull request #414 from dailymotion/readme-typo-394
c1d0e93 
#394: fix typo in the documetation
@ZacharieTFR
Merge pull request #383 from dailymotion/enhancement-readme-update-3.1.1
0008ca0 
Updated the readme to add new public error method to vastTracker API doc
@rgulrajani @ZacharieTFR
Issue-376
5ab458b 
Updated UniversalAdIds for multiple UniversalAdId nodes
@rgulrajani @ZacharieTFR
Issue-376
bb9a596 
Updated the tracker to handle multiple UniversalAdIds for the UNIVERSALADID macro
@rgulrajani @ZacharieTFR
Issue-376
cd2605d 
Updated the tests for supporting multiple UniversalAdIds
@rgulrajani @ZacharieTFR
Updated as per comments from Zach
1ca53f0
@rgulrajani @ZacharieTFR
Issue-376
a0835ad 
Updated the tracker to handle multiple UniversalAdIds for the UNIVERSALADID macro
@PaulineMDaily @ZacharieTFR
ViewableImpression wrapper + typo doc
6ca39a1
@PaulineMDaily @ZacharieTFR
merge wrapper and inline viewable impression
13ffd87
@PaulineMDaily @ZacharieTFR
updated doc
3d6975a
@PaulineMDaily @ZacharieTFR
update comment
58724f4
@PaulineMDaily @ZacharieTFR
updated comment + UT
cc523f8
@PaulineMDaily @ZacharieTFR
updated ad_parser
9ea7041
@PaulineMDaily @ZacharieTFR
fix problem with adVerification nodes merging (updateMergingAdVerific…
e647fc8 
…ation)
@PaulineMDaily @ZacharieTFR
prettier files
540e42b
@rgulrajani @ZacharieTFR
Updated as per comments from Zach
7e50e05
@ZacharieTFR
[tools] Run prettier on all files
e94d90f
@ZacharieTFR
[docs] Update README
6b54de6
clementFrancon
clementFrancon approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clementFrancon clementFrancon merged commit b64cb50 into 4.X Feb 10, 2022
@clementFrancon clementFrancon deleted the 4.X-rebase-3.X-changes branch February 10, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementFrancon clementFrancon clementFrancon approved these changes

Assignees

@ZacharieTFR ZacharieTFR

Labels
enhancement wip Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZacharieTFR @clementFrancon @PaulineMDaily @rumesh @rgulrajani