[#1903] Don't try to dock with ships already docked with yourself #1909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #1906, also don't try to dock with a ship that's already docked with our ship.
For example, given Benedict callsign "Spock" initiated and successfully externally docked to another Benedict callsign "Kirk", "Spock" still appears to "Kirk" as a valid docking target. If "Kirk" attempts to dock with "Spock", "Kirk" enters an endless loop of trying to rotate to dock with "Spock", which moves as "Kirk" rotates.
This could benefit from a potentially recursive check of dockable ships that are docked to ships that are docked to the player; it's still possible to enter an endless docking cycle in those more edge cases of 3+ ships chained together.
This PR also cancels docking if the docking target is moved >1U away from the docking ship.