[PlayerSpaceship] Deprecate redundant energy functions #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oznogon
force-pushed
the
deprecate-player-energy-functions
branch
from
25ed389
to
bd9baa6
Compare
oznogon
changed the title
PlayerSpaceship has redundant getter/setter functions for energy: - `getEnergyLevel()` - `setEnergyLevel()` - `getEnergyLevelMax()` - `setEnergyLevelMax()` Deprecate these in favor of the parent SpaceShip class's functions: - `getEnergy()` - `setEnergy()` - `getMaxEnergy()` - `setMaxEnergy()` Move the PlayerSpaceship energy setter logic, which capped values to a range of 0 to max_energy_level, to the SpaceShip class's behavior, which discarded values less than 0 but accepted all others.
oznogon
force-pushed
the
deprecate-player-energy-functions
branch
from
bd9baa6
to
f183985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerSpaceship has redundant getter/setter functions for energy:
getEnergyLevel()setEnergyLevel()getEnergyLevelMax()setEnergyLevelMax()Deprecate these in favor of the parent SpaceShip class's functions:
getEnergy()setEnergy()getMaxEnergy()setMaxEnergy()Move the PlayerSpaceship energy setter logic, which capped values
to a range of 0 to max_energy_level, to the SpaceShip class's
behavior, which discarded values less than 0 but accepted all
others.
Replace use of these
...EnergyLevel...functions.