fix(helm): allow numeric quoted strings as image tags #8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
gibsondan
approved these changes
May 31, 2022
helm/dagster/charts/dagster-user-deployments/templates/helpers/_helpers.tpl
Show resolved
Hide resolved
rexledesma
force-pushed
the
rl/05-31-fix_helm_allow_numeric_quoted_strings_as_image_tags
branch
from
938e3a4
to
353d08d
Compare
rexledesma
force-pushed
the
rl/05-31-fix_helm_allow_numeric_quoted_strings_as_image_tags
branch
from
353d08d
to
f61fcb7
Compare
rexledesma
deleted the
rl/05-31-fix_helm_allow_numeric_quoted_strings_as_image_tags
branch
OwenKephart
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A follow up to #7579. Although raw integers are supported, quoted integers and quoted floats are not. Fix that.
The root issue stems from helm/helm#1707. We cannot parse raw floats effectively, as they will get converted to scientific notation. They must be passed in as strings.
How I Tested These Changes
pytest