Merge pull request #12 from dachcom-digital/p10-6

Pimcore 10.6 release
dachcom-digital · Jul 7, 2023 · be14e81 · be14e81
2 parents 56a7b34 + 98b4d9f
commit be14e81
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml
@@ -38,12 +38,12 @@ jobs:
                 options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
         strategy:
             matrix:
-                php: [ 8.0 ]
+                php: [ 8.1 ]
                 symfony: [ ^5.4 ]
-                pimcore: [ ~10.5.0 ]
+                pimcore: [ ~10.6.0 ]
                 include:
-                    -   pimcore: ~10.5.0
-                        template_tag: v10.2.0
+                    -   pimcore: ~10.6.0
+                        template_tag: v10.2.5
         steps:
             -   uses: actions/checkout@v2
                 with:

diff --git a/.github/workflows/ecs.yml b/.github/workflows/ecs.yml
@@ -37,12 +37,12 @@ jobs:
                 options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
         strategy:
             matrix:
-                php: [ 8.0 ]
+                php: [ 8.1 ]
                 symfony: [ ^5.4 ]
-                pimcore: [ ~10.5.0 ]
+                pimcore: [ ~10.6.0 ]
                 include:
-                    -   pimcore: ~10.5.0
-                        template_tag: v10.2.0
+                    -   pimcore: ~10.6.0
+                        template_tag: v10.2.5
         steps:
             -   uses: actions/checkout@v2
                 with:

diff --git a/.github/workflows/php-stan.yml b/.github/workflows/php-stan.yml
@@ -37,12 +37,12 @@ jobs:
                 options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
         strategy:
             matrix:
-                php: [ 8.0 ]
+                php: [ 8.1 ]
                 symfony: [ ^5.4 ]
-                pimcore: [ ~10.5.0 ]
+                pimcore: [ ~10.6.0 ]
                 include:
-                    -   pimcore: ~10.5.0
-                        template_tag: v10.2.0
+                    -   pimcore: ~10.6.0
+                        template_tag: v10.2.5
         steps:
             -   uses: actions/checkout@v2
                 with:

diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ This Bundles allows you to load social data from different networks like Faceboo
 ### Release Plan
 | Release | Supported Pimcore Versions | Supported Symfony Versions | Release Date | Maintained     | Branch                                                                 |
 |---------|----------------------------|----------------------------|--------------|----------------|------------------------------------------------------------------------|
-| **2.x** | `10.1` - `10.5`            | `5.4`                      | 05.01.2022   | Feature Branch | master                                                                 |
+| **2.x** | `10.1` - `10.6`            | `5.4`                      | 05.01.2022   | Feature Branch | master                                                                 |
 | **1.x** | `6.0` - `6.9`              | `3.4`, `^4.4`              | 27.04.2020   | Unsupported    | [1.x](https://github.com/dachcom-digital/pimcore-social-data/tree/1.x) |
 
 ## Installation

diff --git a/src/SocialDataBundle/Manager/SocialPostManager.php b/src/SocialDataBundle/Manager/SocialPostManager.php
@@ -115,7 +115,7 @@ public function persistSocialPostEntity(Concrete $post, FeedInterface $feed, boo
 
     protected function persistMedia(FeedInterface $feed, SocialPostInterface $socialPost, bool $forceProcessing): void
     {
-        if (empty($socialPost->getPosterUrl()) || !is_string($socialPost->getPosterUrl())) {
+        if (empty($socialPost->getPosterUrl())) {
             // @todo: how to handle force processing (e.g. delete current asset?)
             $this->logger->debug(sprintf('No poster url given for social post %s', $socialPost->getSocialId()), [$feed]);