Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P11] add twig >= 3.9 (only) suppport #47

Merged
merged 1 commit into from Apr 30, 2024
Merged

[P11] add twig >= 3.9 (only) suppport #47

merged 1 commit into from Apr 30, 2024

Conversation

solverat
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #45

Starting with 3.1, Emailizr only supports Twig 3.9

@solverat solverat added this to the 3.1.0 milestone Apr 30, 2024
@solverat solverat merged commit b7cc8f4 into master Apr 30, 2024
3 checks passed
@solverat solverat deleted the twig_fix_upport branch April 30, 2024 08:54
@dpfaffenbauer
Copy link
Contributor

@solverat doesn't this break Pimcore features like glossary or custom block rendering?

@solverat
Copy link
Member Author

solverat commented May 1, 2024

@dpfaffenbauer not sure, what you mean. It's basically the same as before. We're just using yield instead of echo and the new CaptureNode instead of the ob_get_clean.

@dpfaffenbauer
Copy link
Contributor

Pimcore itself doesn't work with twig 3.9. you require it and pimcore is conflicting it.

@solverat
Copy link
Member Author

solverat commented May 1, 2024

Ah, ok. Well, you can't install emailizr 3.1, as long pimcore doesn't support twig 3.9. But this conflict in pimcore is just temporarily.

For now:

  • emailizr 3.0 => with conflict
  • emailizr 3.1 => twig 3.9 support

@dpfaffenbauer
Copy link
Contributor

@solverat you know how temporary stuff is in Pimcore right ;) Just wanted to make sure you know that emailizr is incompatible with Pimcore now. I don't see the point in this quick change when Pimcore is not ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants