Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: canvas line annotations have separate label & line decorate fns #1632

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: canvas line annotations have separate label & line decorate fns #1632

wants to merge 3 commits into from

Conversation

ColinEberhardt
Copy link
Member

fixes #1628 #1158

@ColinEberhardt
feat: canvas line annotations have separate label & line decorate fns
8d7d485 
BREAKING CHANGE: Previously canvas line annotations had a single `decorate` property. This has been removed and replaced with two decorate functions, `lineDecorate` which is invoked before the line is rendered, and `labelDecorate` which is invoked before the label is rendered.
chrisprice
chrisprice approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@chrisprice chrisprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will change the screenshots, any chance you can regenerate them?

@cfisher-scottlogic cfisher-scottlogic added this to the Triage PRs milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisprice chrisprice chrisprice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Triage PRs
Development

Successfully merging this pull request may close these issues.

Cannot reposition labels with canvas crosshair / line annotation
3 participants
@ColinEberhardt @chrisprice @cfisher-scottlogic