Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning NETSDK1071 #22

Closed
wants to merge 2 commits into from
Closed

Fix compiler warning NETSDK1071 #22

wants to merge 2 commits into from

Conversation

hangy
Copy link

@hangy hangy commented Feb 20, 2019

According to https://aka.ms/sdkimplicitrefs, ASP.NET Core should use implicit package versions and only restrict the version using RuntimeFramework.

According to https://aka.ms/sdkimplicitrefs, ASP.NET Core should use
implicit package versions and only restrict that by using
RuntimeFramework
@hangy
Copy link
Author

hangy commented Feb 21, 2019

@ckuetbach regarding today's discussion: I was able to successfully deploy this PR's branch to AWS lambda: https://48bxyvz559.execute-api.eu-central-1.amazonaws.com/prod/hangy-netsdk/ So it seems that the RuntimeFramework element is enough to satisfy AWS Lambda's .NET Core version restriction.

@ckuetbach ckuetbach self-assigned this Feb 26, 2019
@ckuetbach
Copy link
Member

@hangy thanks for you PR.

It works as expected, but I still have a question. You mention (and changed) RuntimeFramework. But at the provided link, there is only a describtion for a RuntimeFrameworkVersion element.

Was this a mistake? Or do you have another Documentation about RuntimeFramework?

@hangy
Copy link
Author

hangy commented Feb 26, 2019

No, you're absolutely right. I'm a bit confused that this change worked in the first place. 😕 I've replaced RuntimeFramework with RuntimeFrameworkVersion, so that this issue should be fixed.

@ckuetbach
Copy link
Member

I think this would not be the same, because it is meant exact the oposite way.

The runtime must be that version or newer, but we nee to ensure, that we do use feature of newer versions.

I hink dotnet/sdk#2602 this would be helpful.

@ckuetbach
Copy link
Member

I will close this Issue as won't fix, because with dotnet core 3.1 a lot of tooling will change.

See:
#49 and aws/aws-lambda-dotnet#554

@ckuetbach ckuetbach closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants