Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API to change style #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marimeireles
Copy link
Collaborator

@marimeireles marimeireles commented Aug 4, 2021

This PR fixes the buggy behavior seen here

We still need some tests!
Forgot to add those. If anyone is feeling like it, please go ahead!

Otherwise I'll add them eventually :)

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Binder 👈 Launch a binder notebook on branch marimeireles/ipycytoscape/style

@marimeireles
Copy link
Collaborator Author

This PR does affect the behavior of ipycytoscape because before people were counting on the complete erasure of the style to add their new styles.
So now... We either have to fix the examples by adding clear_style every time someone adds a new style to the cytoscape obj or better yet we conform to the new API added here.
I'm thinking about also writing something on the README to let users know of this API change. It ended up having more impacts than I first anticipated. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant