Default Merge #159
Default Merge #159
Conversation
✅ Deploy Preview for voluble-rugelach-5a3809 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,73 @@ | |||
| .p-dropdown-panel { | |||
There was a problem hiding this comment.
I think the current convention for this codebase is to not make separate css files for components, the css is just inline in the sx or style props.
@keiono any thoughts on this?
In my opinion, not a big deal for now though.
There was a problem hiding this comment.
Emmm, if I use cx or style, I think it will cause some code duplications since there are some components with the same class sharing the same style.
There was a problem hiding this comment.
What is the purpose of this file?
There was a problem hiding this comment.
This is a file for icons, originally I wanted to put the icons aside the button 'union', 'intersection' and 'difference' just like the cytoscape desktop, but I encountered some difficulty in showing them correctly, so for now I just keep it here.
|
I commented out the 'Advanced options' in the dialog window just for the workshop since for now it is not so stable without the implementation of 'Type coercion'. |
Default Merge