Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table data loader #158

Merged
merged 61 commits into from
May 15, 2024
Merged

Table data loader #158

merged 61 commits into from
May 15, 2024

Conversation

d2fong
Copy link
Member

@d2fong d2fong commented May 13, 2024

Table data loader and table join

  • add ui forms for creating a network from table data

Summary changes

  • add a isNdex field to the summary model to determine if it is a ndex network or local network
  • disable overwrite to ndex menu item if a network is local

Default layout changes

  • dont run a layout if summary.hasLayout is true
  • if the network doesnt have a layout:
    • run grid layout if the network has more than the threshold of network elements
    • run hierarchical if the network is hcx and has less than the threshold of network elements
    • run force directed if the network is not hcx and has less than the threshold of network elements

- add ui to indicate whether a network is local or from ndex
- disable 'overwrite to ndex' menu item for local networks
- skip empty lines when parsing csvs
- fix bug where invalid row messages would only show in the table form if there were more than one invalid row
- only run a layout if the network doesnt have one and it is under the max network element threshold
- run grid layout for networks with more than 700 elements
Copy link

netlify bot commented May 13, 2024

Deploy Preview for voluble-rugelach-5a3809 ready!

Name Link
🔨 Latest commit 257da22
🔍 Latest deploy log https://app.netlify.com/sites/voluble-rugelach-5a3809/deploys/6644ae5803290d000804c972
😎 Deploy Preview https://deploy-preview-158--voluble-rugelach-5a3809.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@keiono keiono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two remaining issues should be resolved in separate PR. Other than that, I confirmed basic functions work.

@d2fong d2fong merged commit 56df8c1 into development May 15, 2024
@keiono keiono deleted the table-data-loader branch May 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants