Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding initial model based feature importance #323

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctr26
Copy link

@ctr26 ctr26 commented Sep 20, 2023

modified from EmbeddedArtistry

Description

Thank you for your contribution to pycytominer!
Please succinctly summarize your proposed change.
What motivated you to make this change?

Please also link to any relevant issues that your code is associated with.

What is the nature of your change?

  • Enhancement (adds functionality).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

Hi all,

I've unintentionally been working on my own similiar code base for years. If it's ok with you I'm going to upstream some of the code and modules that I think you're currently missing that would be helpful, particularly around extracting feature importances and model fitting. Hoping this is ok.

@gwaybio
Copy link
Member

gwaybio commented Sep 20, 2023

Thanks @ctr26 , we certainly welcome your contributions and we'd be delighted to include them!

We'll be happy to review this PR when it's ready, and we highly recommend adding functionality bit by bit. This will make review much more streamlined and effective.

I'll also provide two additional notes:

  • please review our Contributing guide when you get a chance (if you haven't already of course!)
  • we strive for high test coverage, so we are likely to be sticklers about testing

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants