string/iter/shutdown limited API fixes #6169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to: * some string methods * iter next (due to type slots) * module cleanup (temporary fix because access to module state is unreliable)
|
This is basically just linked by fixing some tests in "tests/run" which begin with "b". |
da-woods
commented
Apr 28, 2024
| # (e.g. during interpreter shutdown). | ||
| # In that case the safest thing is to give up. | ||
| code.putln(f"if (!PyState_FindModule(&{Naming.pymoduledef_cname}))") | ||
| code.putln("return;") |
There was a problem hiding this comment.
I think this change won't be needed after #5323. That's the "right" fix, and this is just a fairly quick temporary measure.
There was a problem hiding this comment.
I'm less convinced it'll be completely unneeded after a bit more thought (since destructors can call into arbitrary code outside the module's cleanup function). Further refactors to reduce the dependence of PyState_FindModule will help though. And we might be able to split it into cached constants (safe) and everything else (unsafe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to: