[0.29.x] Fix Python 3.12 tests #6135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 12, 2024
This package requires cython<3.0 and we need cython 3 because cython 0 tests does not run on python 3.12. Nothing else depends on py3-thinc so remove. We can re-add this package when upstream adds support for cython 3 if needed. ref: https://github.com/explosion/thinc/blob/3aae298d32adc167ac57e0791a5a8c0544b1e8a5/pyproject.toml#L4 ref: cython/cython#6135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were almost all failing because
import impno longer works. To fix this I've backported 48325b4I'll also tried removing "allow_failure" on Python 3.12 to see what happens. I suspect this'll need to be reverted.