Create standalone cython runtime module package #6132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cython#1981 Package is named Cython_shadow. That can probably be changed. It doesn't attempt to deal with any versioning issues. It also doesn't do any testing. That'd probably be a case of adding a ci run that makes and installs the wheel and then imports a few example pure-Python modules. Not sure what else I'm missing.
|
I'm created this as a draft because 1) I'm not completely sure this is a good idea, and 2) it's missing any kind of testing |
matusvalo
reviewed
Apr 6, 2024
| @@ -0,0 +1 @@ | |||
| ../cython.py | |||
There was a problem hiding this comment.
I think this file should not be symbolic link but new file since this file imports also Cython.Compiler.Main
There was a problem hiding this comment.
For now I think I'll catch any import error and print a message.
Shadow file is already tested in: |
Probably just that the wheel does provide the imports that I think it does. So not a huge amount of testing, but a little bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1981
Package is named Cython_shadow. That can probably be changed.
It doesn't attempt to deal with any versioning issues.
It also doesn't do any testing. That'd probably be a case of adding a ci run that makes and installs the wheel and then imports a few example pure-Python modules.
Not sure what else I'm missing.