-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compilation cache to cython command #6091
base: master
Are you sure you want to change the base?
Conversation
6e6abee
to
5e32b6c
Compare
Co-authored-by: da-woods <dw-git@d-woods.co.uk>
Co-authored-by: da-woods <dw-git@d-woods.co.uk>
Co-authored-by: da-woods <dw-git@d-woods.co.uk>
Rebased from master containing refactor of Cache code. Now PR is clean and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess that it could be cleaner if the caching (not necessarily the Cache object creation) was done just around the call to run_pipeline()
. Maybe add a wrapper function run_cached_pipeline
?
implemented. |
Adds
--cache
argument to cython command. It is built on top of #6090 and should be merged after it.I suppose additional tests are needed to this PR. I will try to add to this PR.Tests added.
Related to #6070