Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compilation cache to cython command #6091

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

matusvalo
Copy link
Contributor

@matusvalo matusvalo commented Mar 16, 2024

Adds --cache argument to cython command. It is built on top of #6090 and should be merged after it.

I suppose additional tests are needed to this PR. I will try to add to this PR.

Tests added.

Related to #6070

@matusvalo matusvalo added this to the 3.1 milestone Mar 16, 2024
@matusvalo
Copy link
Contributor Author

Rebased from master containing refactor of Cache code. Now PR is clean and ready for review.

Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess that it could be cleaner if the caching (not necessarily the Cache object creation) was done just around the call to run_pipeline(). Maybe add a wrapper function run_cached_pipeline?

Cython/Compiler/Main.py Outdated Show resolved Hide resolved
Cython/Compiler/Main.py Outdated Show resolved Hide resolved
Cython/Compiler/Main.py Show resolved Hide resolved
@matusvalo
Copy link
Contributor Author

Maybe add a wrapper function run_cached_pipeline?

implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants