Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage of numpy_math.pyx #6075

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Mar 14, 2024

Replaces #5967

  • Add tests so that all the routines and constants are tested
  • Add constants to numpy_math.pxd (is this possible) instead of pulling from NumPy
  • Add non-C99 routines to numpy_math.pxd as inline functions
  • Take equivalent routines from math.h instead of from numpy/math.h, but be careful around ones that can be blocklisted, especially on MSVC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant