misc: receive afterSpec durations from app capture code, and report them to the Cloud API #29500
+273
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
commented
May 9, 2024
| @@ -289,6 +290,9 @@ export type ProtocolMetadata = ArtifactMetadata & { | |||
| size: number | |||
| offset: number | |||
| } | |||
| afterSpecDurations?: AfterSpecDurations & { | |||
There was a problem hiding this comment.
AfterSpecDurations is the shape that the protocol capture codebase will return; we're augmenting that with the total duration of afterSpec, so the shape is modified here.
4 flaky tests on run #55569 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Review all test suite changes for PR #29500 ↗︎ | |
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
| await this.invokeAsync('afterSpec', { isEssential: true }) | ||
| const startTime = performance.now() + performance.timeOrigin | ||
|
|
||
| debug({ startTime }) |
There was a problem hiding this comment.
Should we have a description here around what this is?
There was a problem hiding this comment.
I think this debug can be removed- the important debug is on L191
| fileSize: number | bigint | ||
| specAccess: ReturnType<AppCaptureProtocolInterface['getDbMetadata']> | ||
| } | undefined> { | ||
| async uploadCaptureArtifact ({ uploadUrl, fileSize, filePath }: CaptureArtifact, captureErrorsOverride?: boolean) { |
There was a problem hiding this comment.
Is captureErrorsOverride just used for testing purposes?
There was a problem hiding this comment.
Yep. Could refactor a bit to have caller pass in the env var to make things a little cleaner.
cacieprins
commented
May 23, 2024
mschile
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Because of the bifurcation of Test Replay capture/upload logic, the durations that are recorded in the afterSpec process will be returned from the protocol capture codebase' afterSpec method. They're collected and reported to the
updateInstanceArtifactsCloud API endpoint.Steps to test
Verify that, once the related services PR is merged and released, these durations are reported to the update instance artifacts endpoint when recording a spec with Test Replay enabled. When running against staging, these durations should be queryable in Honeycomb.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?