Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update dependency js-cookie to v3 #29497

Merged
merged 3 commits into from May 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
js-cookie 2.2.1 -> 3.0.5 age adoption passing confidence

Release Notes

js-cookie/js-cookie (js-cookie)

v3.0.5

Compare Source

  • Remove npm version restriction in package.json - #​818

v3.0.4

Compare Source

  • Publish to npmjs.com with package provenance

v3.0.3

Compare Source

v3.0.2

Compare Source

v3.0.1

Compare Source

  • Make package.json accessible in export - #​727

v3.0.0

Compare Source

  • Removed defaults in favor of a builder: now to supply an api instance with particular predefined (cookie) attributes there's Cookies.withAttributes(), e.g.:
const api = Cookies.withAttributes({
  path: '/',
  secure: true
})
api.set('key', 'value') // writes cookie with path: '/' and secure: true...
  • The attributes that an api instance is configured with are exposed as attributes property; it's an immutable object and unlike defaults cannot be changed to configure the api.
  • The mechanism to fall back to the standard, internal converter by returning a falsy value in a custom read converter has been removed. Instead the default converters are now exposed as Cookies.converter, which allows for implementing self-contained custom converters providing the same behavior:
const customReadConverter = (value, name) => {
  if (name === 'special') {
    return unescape(value)
  }
  return Cookies.converter.read(value)
}
  • withConverter() no longer accepts a function as argument to be turned into a read converter. It is now required to always pass an object with the explicit type(s) of converter(s):
const api = Cookies.withConverter({
  read: (value, name) => unescape(value)
})
  • The converter(s) that an api instance is configured with are exposed as converter property; it's an immutable object and cannot be changed to configure the api.
  • Started providing library as ES module, in addition to UMD module. The module field in package.json points to an ES module variant of the library.
  • Started using browser field instead of main in package.json (for the UMD variant of the library).
  • Dropped support for IE < 10.
  • Removed built-in JSON support, i.e. getJSON() and automatic stringifying in set(): use Cookies.set('foo', JSON.stringify({ ... })) and JSON.parse(Cookies.get('foo')) instead.
  • Removed support for Bower.
  • Added minified versions to package - #​501
  • Improved support for url encoded cookie values (support case insensitive encoding) - #​466, #​530
  • Expose default path via API - #​541
  • Handle falsy arguments passed to getters - #​399
  • No longer support Node < 12 when building (LTS versions only)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@jennifer-shehane jennifer-shehane self-assigned this May 9, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. None of the v3 updates impact us since we only call .get and .set. There is some improved support for url encoded cookie values (support case insensitive encoding), which could possibly fix some cookie uses with our users.

@jennifer-shehane jennifer-shehane changed the title chore(deps): update dependency js-cookie to v3 dependency: update dependency js-cookie to v3 May 9, 2024
Copy link
Contributor Author

renovate bot commented May 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

cypress bot commented May 9, 2024

1 flaky test on run #55366 ↗︎

0 230 4 0 Flakiness 1

Details:

Add changelog
Project: cypress Commit: b50460c449
Status: Passed Duration: 11:12 💡
Started: May 9, 2024 8:09 PM Ended: May 9, 2024 8:20 PM
Flakiness  cypress/e2e/project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
... > skips the setup steps when choosing component tests to run Test Replay Screenshots

Review all test suite changes for PR #29497 ↗︎

@jennifer-shehane jennifer-shehane merged commit 6a49c56 into develop May 10, 2024
80 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the renovate/js-cookie-3.x branch May 10, 2024 20:19
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 21, 2024

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants