Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert making check-ts resource-class smaller #29484

Merged
merged 2 commits into from May 7, 2024

Conversation

jennifer-shehane
Copy link
Member

Additional details

I had previously made an attempt to rightsize circleci jobs here, including reducing the resources for the check-ts job. This appears to be causing some cryptic failures with check-ts since it doesn't have enough resources: https://circleci.com/gh/cypress-io/cypress/2555779

Steps to test

check-ts job passes

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this May 7, 2024
@mschile mschile requested a review from ryanthemanuel May 7, 2024 16:15
@jennifer-shehane
Copy link
Member Author

Merging since check-ts check is now passing

@jennifer-shehane jennifer-shehane merged commit b31740c into develop May 7, 2024
74 of 81 checks passed
@jennifer-shehane jennifer-shehane deleted the revert-small-check-ts-resource branch May 7, 2024 17:37
Copy link

cypress bot commented May 7, 2024

14 flaky tests on run #55333 ↗︎

0 29193 1328 0 Flakiness 14

Details:

empty commit
Project: cypress Commit: 8b114b95cd
Status: Passed Duration: 19:39 💡
Started: May 7, 2024 5:18 PM Ended: May 7, 2024 5:37 PM
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-firefox

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55333/overview/6c58d305-ec3c-4369-b5c5-d59e804bb74a?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        network stubbing > intercepting request > delay works correctly with 204 No Content
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > stops waiting when an fetch request is canceled Test Replay
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > times out in cy.origin with foobar spec bridge defined Test Replay
Flakiness  commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome:beta

View Output

Test Artifacts
... > errors > throws when route is never resolved Test Replay
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when waiting for 2nd response to route Test Replay

The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.

Review all test suite changes for PR #29484 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants