Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cypress-example-kitchensink to v2.0.7 #29480

Merged
merged 3 commits into from May 8, 2024

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Steps to test

Ubuntu 22.04.4 LTS, Node.js 18.17.1

Prepare unconfigured project using Node.js 20.22.2 LTS:

mkdir cy-test
cd cy-test
git init
npm init -y
npm install cypress @eslint/eslintrc @stylistic/eslint-plugin-js eslint eslint-plugin-cypress eslint-plugin-jsonc eslint-plugin-mocha -D

Copy eslint.config.mjs from cypress-example-kitchensink into root of cy-test

Switch to Node.js 18.17.1

Build and run Cypress
cd to cypress clone

yarn
yarn start
In Cypress Launchpad select project cy-test from above.
Select E2E Testing
Select Continue
Select Electron
Select Start E2E Testing in Electron
Select "Scaffold example specs"
Select "Okay, I got it!"

Close Cypress Runner and Cypress Dashboard

cd to cy-test project and switch to Node.js 20.22.2 LTS

npx cypress run
npx eslint cypress

How has the user experience changed?

An unreported indent issue in the second to last line of the scaffolded cypress/e2e/2-advanced-examples/navigation.cy.js has been resolved. This was caused by the build process yarn workspace @packages/example build stripping eslint strings and disturbing the formatting. The root cause is not fixed, however the eslint string /* eslint-enable no-unused-vars */ is now removed from the source on cypress-example-kitchensink (see PR cypress-io/cypress-example-kitchensink#837) and so the problem is no longer exposed.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
    The contents of the optionally installed scaffolded E2E test specs are undocumented in https://docs.cypress.io so no changes to the documentation are necessary.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor Author

Log of linting errors (expected)

$ npx eslint cypress

/home/mike/github/cy-test/cypress/e2e/2-advanced-examples/cypress_api.cy.js
  31:46  error  '$button' is defined but never used  no-unused-vars

/home/mike/github/cy-test/cypress/e2e/2-advanced-examples/utilities.cy.js
  87:44  error  'reject' is defined but never used  no-unused-vars

/home/mike/github/cy-test/cypress/e2e/2-advanced-examples/viewport.cy.js
  28:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  30:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  32:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  34:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  36:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  38:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  40:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  42:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  44:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  46:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  51:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  53:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting

/home/mike/github/cy-test/cypress/e2e/2-advanced-examples/waiting.cy.js
  12:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  14:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting
  16:5  error  Do not wait for arbitrary time periods  cypress/no-unnecessary-waiting

✖ 17 problems (17 errors, 0 warnings)

@jennifer-shehane jennifer-shehane merged commit 375cc29 into cypress-io:develop May 8, 2024
67 checks passed
@MikeMcC399
Copy link
Contributor Author

Successfully retested after merge of this PR (see steps in original post).

Cypress is now 13.9.0 and Node.js is 20.13.0 LTS

@MikeMcC399 MikeMcC399 deleted the update/kitchensink branch May 8, 2024 17:01
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 21, 2024

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants