fix: update firefox to close extra windows between specs #29475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,8 +136,8 @@ const connect = function (host, path, extraOpts) { | |||
| return invoke('takeScreenshot', id) | |||
| case 'reset:browser:state': | |||
| return invoke('resetBrowserState', id) | |||
| case 'reset:browser:tabs:for:next:test': | |||
| return invoke('resetBrowserTabsForNextTest', id) | |||
| case 'reset:browser:tabs:for:next:spec': | |||
There was a problem hiding this comment.
Thanks for fixing my bad naming.
ryanthemanuel
approved these changes
May 6, 2024
AtofStryker
approved these changes
May 6, 2024
10 flaky tests on run #55322 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > skips the setup page when choosing e2e tests to run |
Test Replay
Screenshots
|
|
| Launchpad: Setup Project > openLink > opens docs link in the default browser |
Test Replay
Screenshots
|
|
runner/sessions.ui.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| runner/cypress sessions.ui.spec > creates, not recreates, session when validation fails then succeeds |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #29475 ↗︎
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In
firefox, if window.open is used to open a new window, we do not close the extra window between specs which can lead to issues in subsequent specs such as performance issues in service workers.background.jsto close the extra windows between specsresetBrowserTabsForNextTesttoresetBrowserTabsForNextSpecSteps to test
Run a test that opens a new window in
firefoxand verify it gets closed between specs.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?