Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nvm on windows so we can install node 20 in kitchensink binary test #28576

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

Windows nvm 1.1.9 would try to install an arm64 msi for node 20, which kitchensink requires. Upgrading to windows nvm 1.1.11 fixes this.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review December 22, 2023 13:00
Copy link

cypress bot commented Dec 22, 2023

5 flaky tests on run #52985 ↗︎

0 5371 80 0 Flakiness 5

Details:

Update workflows.yml
Project: cypress Commit: ff8068e5c3
Status: Passed Duration: 14:29 💡
Started: Dec 22, 2023 2:38 PM Ended: Dec 22, 2023 2:52 PM
Flakiness  commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
src/cy/commands/storage > #getAllLocalStorage > gets local storage from all origins Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
Flakiness  e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior) Test Replay

Review all test suite changes for PR #28576 ↗︎

@MikeMcC399
Copy link
Contributor

@cacieprins

Did you consider using the latest version
https://github.com/coreybutler/nvm-windows/releases/tag/1.1.12 ?

@cacieprins
Copy link
Contributor Author

@cacieprins

Did you consider using the latest version https://github.com/coreybutler/nvm-windows/releases/tag/1.1.12 ?

I did - I wanted to make the minimal amount of changes for now, however.

@cacieprins cacieprins merged commit fd02263 into develop Dec 22, 2023
81 of 83 checks passed
@cacieprins cacieprins deleted the cacie/chore/fix-nvm-windows-ci branch December 22, 2023 17:16
@MikeMcC399
Copy link
Contributor

@cacieprins

Did you consider using the latest version https://github.com/coreybutler/nvm-windows/releases/tag/1.1.12 ?

I did - I wanted to make the minimal amount of changes for now, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants