chore: update contributor workflow to include approval job #27822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a separate linux-x64 workflow that runs on contributor PRs (any PR where the branch matches
/^pull\/[0-9]+/
).In this contributor workflow there are two differences:
build
step does not use thetest-runner:env-canary
context. We don't need this in the contributor workflow and it is causing "unauthorized" errors, not allowing contributor PR runs to get past the build step (for example)create-and-trigger-packaging-artifacts
(and by extension, all of the binary test jobs) from running. So, when the workflow runs, it will run everything except the binary build and test jobs. Then, when a member of our team sees the PR, they can click the "approve" button next to the job, and it should allow access to the contexts needed to run the workflow. This strategy is described in the CircleCI docsThere isn't a good way to test this without merging into develop. We can test that the existing workflow is working, but we can't run the contributor PR workflow off of a branch. When CI spins up for a contributor PR, we pull the
workflows.yml
file from thedevelop
branch here.