Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributor workflow to include approval job #27822

Merged
merged 6 commits into from Sep 20, 2023

Conversation

astone123
Copy link
Contributor

This PR creates a separate linux-x64 workflow that runs on contributor PRs (any PR where the branch matches /^pull\/[0-9]+/).

In this contributor workflow there are two differences:

  • the build step does not use the test-runner:env-canary context. We don't need this in the contributor workflow and it is causing "unauthorized" errors, not allowing contributor PR runs to get past the build step (for example)
  • there is an approval job called approve-binary-build that blocks the create-and-trigger-packaging-artifacts (and by extension, all of the binary test jobs) from running. So, when the workflow runs, it will run everything except the binary build and test jobs. Then, when a member of our team sees the PR, they can click the "approve" button next to the job, and it should allow access to the contexts needed to run the workflow. This strategy is described in the CircleCI docs

There isn't a good way to test this without merging into develop. We can test that the existing workflow is working, but we can't run the contributor PR workflow off of a branch. When CI spins up for a contributor PR, we pull the workflows.yml file from the develop branch here.

@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #51174 ↗︎

0 84 0 0 Flakiness 0

Details:

Merge branch 'develop' into astone123/update-contributor-workflow
Project: cypress Commit: d23a460e14
Status: Passed Duration: 05:25 💡
Started: Sep 20, 2023 3:06 PM Ended: Sep 20, 2023 3:11 PM

Review all test suite changes for PR #27822 ↗︎

@astone123 astone123 merged commit a9d2dc2 into develop Sep 20, 2023
81 of 82 checks passed
@astone123 astone123 deleted the astone123/update-contributor-workflow branch September 20, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants