Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs to reflect LayerCI changes to webapp.io #5632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuadsouza
Copy link

LayerCI rebranded to webapp.io, context here: https://webapp.io/blog/layerci-has-rebranded-to-webapp-io/

This PR does the following:

Copy link

netlify bot commented Feb 6, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f222478

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit f222478
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65c2071088cb2b00089a89ce
😎 Deploy Preview https://deploy-preview-5632--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 14, 2024

@jennifer-shehane
Copy link
Member

@MikeMcC399 Good point outs. We can address those concerns seperately.

@@ -454,6 +454,10 @@ to see why the commit information is unavailable.
DEBUG=commit-info,cypress:server:record
```

:::info
Cypress versions less than 3.15.0 will need to manually provide the CI ENVs to correctly send their SCM to the Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a valid Cypress version. I'm not sure what @emilyrohrbough was trying to convey in their original comment. I think she meant the version that this is released in? cypress-io/cypress#28577 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest Cypress 3.x version released was cypress@3.8.3 in Jan 2020, so I would not have thought it is necessary to draw attention to such an old and legacy version.

With the exception of the Configuration (Legacy) page and the Migration Guide it is more or less assumed that the user has at the minimum Cypress 10.x if not Cypress 13.x running.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuadsouza are you able to make these updates?

@@ -179,5 +179,5 @@ and

### webapp.io

- [cypress-example-layerci](https://github.com/bahmutov/cypress-example-layerci)
- [Using cypress with webapp.io](https://webapp.io/docs/integrations/cypress)
- [Basic Example (Layerfile)](https://github.com/webappio/react-e2e-example/blob/master/Layerfile)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of me asking for this update was so that we don't have to specify --ci-build-id on the cypress command, but if I upgrade to 13.6.5 and remove the flag in Webapp.io, I get the error:

{
  "message": "CI Build ID could not be generated and was not specified.",
  "code": "INDETERMINATE_CI_BUILD_ID"
}

@jennifer-shehane Could we perhaps setup a cloud account for Webapp.io for testing purposes and then @joshuadsouza could update the example above to use the --record flag and thus verify that this integration works as expected with Cypress Cloud?

I'm really trying to remove the use of --ci-build-id because it makes the command non-deterministic and messes up the content-aware caching I'm trying to setup with Turborepo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianwalter Could you open a new issue in the cypress repo? I think we may need to make a Cloud change to address this, but it won't be tracked well as a comment in this PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants