Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui):make view for module dynamic #265

Merged
merged 2 commits into from
May 16, 2024

Conversation

Tapasvi48
Copy link
Contributor

@Tapasvi48 Tapasvi48 commented May 14, 2024

closes #255

📑 Description

made rendering of module dynamic and set max width for module size

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Additional context

@Tapasvi48 Tapasvi48 requested a review from a team as a code owner May 14, 2024 10:51
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Tapasvi48! That's what we were looking for, but we missed this antd config. I just left one comment.

cyclops-ui/src/components/pages/Modules/Modules.tsx Outdated Show resolved Hide resolved
Co-authored-by: Petar Cvitanović <72022639+petar-cvit@users.noreply.github.com>
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tapasvi48!

@petar-cvit petar-cvit merged commit 6a4e728 into cyclops-ui:main May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic number of Module list columns
2 participants