Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(sort fields): based on order and alphabetic priority #261

Closed
wants to merge 1 commit into from

Conversation

Tanmay-21
Copy link
Contributor

@Tanmay-21 Tanmay-21 commented May 7, 2024

closes #228

📑 Description

Added Functionality to sort values based on first the order provided and then the alphabetic priority of remaining values.
Approach : add index numbers based on order to a map against the value names and base on alphabetic order for remaining values + the size of order so that numbers don't clash and alphabetic order gets higher numbers so lesser priority.

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Additional context

@Tanmay-21 Tanmay-21 requested a review from a team as a code owner May 7, 2024 21:34
@petar-cvit
Copy link
Collaborator

Hey @Tanmay-21, this was implemented in #230, so Im closing this PR

@petar-cvit petar-cvit closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort fields from values.schema.json
2 participants