-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort fields from values.schema.json
#228
Comments
Hey @petar-cvit I would like to work on this!! |
Issue: cyclops-ui#228 1. Sorted the fields from values.schema.json into the alphabetical form when the order is not provided 2. When order is provided , the defined fields will come in order first and then the sorted fields.
@Sheikh-Abubaker thanks, but @RohanMishra315 already opened a PR for it |
@petar-cvit no worries! |
@petar-cvit would like to give this a try. |
Hey @petar-cvit, I have raised a PR for the requirement - #261 |
Hey @Tanmay-21. @RohanMishra315 already has a PR for this, so let's wait to hear back from him about this issue |
Is your feature request related to a problem? Please describe.
Cyclops uses an additional field
order
provided in thevalues.schema.json
that allows users to set a custom order of fields in the object in their schemas (e.g. here)However, most templates won't have this field set and their children will have a random order. The scope of this issue is to order fields alphabetically if
order
is not provided.Another possible case is that order is defined for just a subset of fields. Fields with a defined order should come before those without set order.
Example:
Should be rendered in the to following order:
The first three are defined in the
order
, and the last three are sorted alphabetically. Ordered come before alphabetically sort ones.Describe the solution you'd like
Add alphabetical sorting here
The text was updated successfully, but these errors were encountered: