Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Make captureClicks compatible with history driver push #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 🐛 Make captureClicks compatible with history driver push #943

wants to merge 1 commit into from

Conversation

shesek
Copy link
Contributor

@shesek shesek commented Apr 22, 2020

BREAKING CHANGE: 🧨 captureClicks will no longer combine the search/hash into the pathname.

✅ Closes: #909

  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit

@shesek
fix: 🐛 Make captureClicks compatible with history driver push
28f4f42 
BREAKING CHANGE: 🧨 captureClicks will no longer combine the search/hash into the pathname.

✅ Closes: cyclejs#909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

History pathname can no longer contain the search query and/or hash
1 participant
@shesek