Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start-parameter to progress_bar #397

Open
wants to merge 1 commit into
base: skia_2024
Choose a base branch
from

Conversation

Flole998
Copy link
Contributor

@Flole998 Flole998 commented May 4, 2024

This parameter specifies where the progress_bar starts. It can be used to implement a busy-indicator for example.

This parameter specifies where the progress_bar starts. It can be used
to implement a busy-indicator for example.
@Flole998 Flole998 changed the base branch from master to skia_2024 May 4, 2024 00:31
@djowel
Copy link
Collaborator

djowel commented May 4, 2024

There should be a better way. One of the primary rules I adhere to is that the user should not pay for features that he does not use. I might sometimes break that rule if the functionality is used often enough, at least 50% of the time. This is not the case here.

I think this can be better served as a derived class or even a totally separate class which provides the desired behavior, without adding any extra member variable.

@djowel djowel self-assigned this May 4, 2024
@djowel djowel force-pushed the skia_2024 branch 2 times, most recently from d57375f to 793c02f Compare May 22, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants