This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Don't assume the app is in /app, expose env variables to subsequent buildpack #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any information on this topic? |
|
Hey @mobilutz, I think I managed to resolve the conflict 😄 |
mobilutz
reviewed
Jan 16, 2019
bin/compile
Outdated
| @@ -15,13 +15,17 @@ S3_BUCKET=${HEROKU_GEO_BUILDBACK_S3_BUCKET:-"heroku-buildpack-geo"} | |||
|
|
|||
| # Parameters | |||
| BUILD_DIR=$1 | |||
| BP_DIR=$(cd $(dirname ${0:-}); cd ..; pwd) | |||
There was a problem hiding this comment.
Is it really necessary here?
Same things is in line 20
There was a problem hiding this comment.
It seems this got screwed when rebasing. I removed the duplicate line. Good catch 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't assume the root is going to be
/app. There are some buildpacks out there that make other buildpacks run in subdirectories and this assumption breaks them.Expose environment variables to subsequent buildpacks (such as the Python one) so that they can also read them.
This seems to fix: #37 #39 #31
It might be a good idea to also pull in: TrailStash@5ae45e5
To fix support for
heroku-16.