Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#95/chore/check new linter ruff #96

Merged
merged 17 commits into from
Apr 27, 2024

Conversation

YoshikiKubotani
Copy link
Collaborator

@YoshikiKubotani YoshikiKubotani commented Aug 31, 2023

Issue URL

Close: #95

Change overview

  • Add the new linter ruff written in Rust, and remove flake8 and isort from dev dependencies
  • Update the python libraries listed on dev dependencies

[Add changes below on 2024/04/27]

  • Replace black with Ruff formatter (released as of v0.1.2)
  • Add the recommended Ruff linter rules compatible with Ruff formatter [link]
  • Remove .flake8 file
  • Describe how to loosen the rules of Ruff in README.md
  • Update README.md representation

How to test

  • Make sure to work make ruff, make ruff-check under the core container
  • Make sure to run make format with no warnings under the core container

Note for reviewers

N/A

Copy link
Contributor

@gatheluck gatheluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@gatheluck
Copy link
Contributor

@YoshikiKubotani
CI is raising error. Can you fix it?

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gatheluck gatheluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one commend about README.md, except that part LGTM!

@YoshikiKubotani YoshikiKubotani merged commit 2cfd4f4 into develop Apr 27, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Check new linter Ruff
2 participants