Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and export of figured bass elements from MEI and musicxml file formats #1539

Closed
wants to merge 226 commits into from

Conversation

mxordn
Copy link
Contributor

@mxordn mxordn commented Mar 22, 2023

(1) Added the possibility to import musicxml and MEI representations of figured bass notations.

(2) Proposes also a class to represent Figured Bass in a music21 stream. The class is called FiguredBassIndication and inherits from the harmony object using the already existing objects from the figuredbass module.

Any comments are highly appreciated. A discussion in the google list is here available: https://groups.google.com/g/music21list/c/-Z_UQfZ9SPk/m/gyE9DciUCgAJ

mscuthbert and others added 25 commits January 6, 2023 15:18
add Aloha Oe -- whose incorrect interpretation caused this
fixed import and moved figuredBassIndication to harmony
Add utility for removing duplicated objects (e.g. keys, clefs) (cuthbertLab#1454)
…t/Trill was not created with accid, and _never_ for HalfStep/WholeStep Mordent/Trill variations.
@mxordn mxordn marked this pull request as ready for review March 22, 2023 23:10
Copy link
Contributor

@gregchapman-dev gregchapman-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment/worry about mei/base.py: I think you started from an older version; you are missing a bunch of stuff that happened in the last year or so (for example the metadata changes I made in v8, and all the typing changes Myke made as well).

@mxordn
Copy link
Contributor Author

mxordn commented Mar 23, 2023

Quick comment/worry about mei/base.py: I think you started from an older version; you are missing a bunch of stuff that happened in the last year or so (for example the metadata changes I made in v8, and all the typing changes Myke made as well).

This is interesting. I synced with the main repo some weeks ago and thought I used the mei/base.py that is in the current master branch. I will have a look at it.

UPDATE: I updated mei/base.py to the newer version. The newer parts didn't affect my changes.

mscuthbert and others added 26 commits June 11, 2023 10:14
Clean up the User's Guide so that docs in progress are separate from released docs.
Move incomplete docs to testsAndInProgress
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@mscuthbert
Copy link
Member

Hi. This PR currently changes 200+ files and has hundreds of commits. This won't be possible to review. Can you close and open a new one just with the changes from the "master" branch?

@mxordn
Copy link
Contributor Author

mxordn commented Jun 13, 2023

As I came back to this topic today, I thought similar. Rebasing my fork to the new version triggered the checks here I think. I'll close this PR and open a new one when I have the stuff ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants