Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Migrate class scope #2332

Merged
merged 3 commits into from
May 15, 2024
Merged

C#: Migrate class scope #2332

merged 3 commits into from
May 15, 2024

Conversation

AndrewDant
Copy link
Collaborator

@AndrewDant AndrewDant commented May 14, 2024 •
edited by pokey

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndrewDant
Copy link
Collaborator Author

In regards to the cheatsheet, if I Run extension and then try to open the cheatsheet from within that window I get the following popup. I'm not sure if that's actually related to changes I've made here, or if I would not normally expect it to work from within that window.
image

@pokey pokey changed the title Andrew dant/csharp scopes C#: Migrate class scope May 15, 2024
@pokey pokey added lang-c# scope-migration Migrating scopes to next-gen scope implementation labels May 15, 2024
pokey
pokey approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tweaked the issue title and added some tags but otherwise good to go

@pokey pokey added this pull request to the merge queue May 15, 2024
@pokey
Copy link
Member

pokey commented May 15, 2024 •
edited

In regards to the cheatsheet, if I Run extension and then try to open the cheatsheet from within that window I get the following popup. I'm not sure if that's actually related to changes I've made here, or if I would not normally expect it to work from within that window.

image

Yeah you need to manually build the cheatsheet. That checkbox is just if you touch talon side tho. I edited your description to mark them as not applicable

Merged via the queue into main with commit f143950 May 15, 2024
15 checks passed
@pokey pokey deleted the AndrewDant/csharp-scopes branch May 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

@AndreasArvidsson AndreasArvidsson Awaiting requested review from AndreasArvidsson AndreasArvidsson is a code owner

Assignees
No one assigned
Labels
lang-c# scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewDant @pokey