isTesting versus ide.runMode

[saidelike]

Checklist

• I have added tests
• I have updated the docs and cheatsheet
• I have not broken the cheatsheet

I initially wanted to get rid of isTesting() entirely an only rely on ide.runMode === "test" and ide.runMode === "production" but it seems that some tests actually don't run as vscode extensions we need the CURSORLESS_TEST environment variable (see launch.json)

I thought about moving the isTesting() to cursorless-engine since it holds the ide and export that specific function to the rest of the world. However there is at least one instance of isTesting() in a package that doesn't import cursorless-engine (packages\cursorless-vscode\src\ide\vscode\VscodeEnabledHatStyleManager.ts) so we can't do that.

That is why I came up with this following approach, even though I'm not entirely happy about it. I can't think about any better way, but at least I think it's better than the current way.

it is all the more not ideal because for neovim I'm using CURSORLESS_MODE set to development or test to set the neovimIde.runMode since it's not given by vscode. consequently I'm never gonna use isTesting(). Consequently we could potentially move this one to vscode specific packages.

[pokey]

hmm if we can't get rid of it entirely, i'd be inclined to just leave things as they are?

[saidelike]

hmm if we can't get rid of it entirely, i'd be inclined to just leave things as they are?

Yes we could tbh. It didn't go as planned lol but i thought i would explain it in this PR anyway. But i also dont really like the old approach but i can't think of a better way atm anyway.

Feel free to close if you want to stick to old method.

[pokey]

might be worth switching to use CURSORLESS_MODE everywhere then instead of CURSORLESS_TEST?

[saidelike]

Ya the advantage of CURSORLESS_MODE is that it is consistent if we vscode extension or not and for other apps than vscode.
The drawback is that we need to specify it for every single task or launch config (as development or test) as otherwise it will be treated as production (when the env variable is not set).

[pokey]

but that's the same problem we have today with CURSORLESS_TEST right?

[saidelike]

Yes when outside of a vscode extension.

But in the case of a vscode extension, the vscodeIDE.runMode gives by default that it is production hence not test or development. But it is in other places where isTesting() is not used.

And that was that inconsistency that i wanted to fix initially.

[pokey]

hmm not sure i'm totally following. maybe let's discuss at a meet-up?