Add cURL's boolean options #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by parsing the output of `curl --help`
verhovsky
commented
Jul 12, 2021
| @@ -1,5 +1,5 @@ | |||
| const cookie = require('cookie') | |||
| const yargs = require('yargs') | |||
| const yargsParser = require('yargs-parser') | |||
There was a problem hiding this comment.
Besides have a different API that chains method calls instead of passing an object, I don't understand what yargs actually does for us over plain yargs-parser, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by parsing the output of
curl --help.I ran into two issues working on this:
curl --helpisn't perfect, see Document that --tlspassword takes a password curl/curl#7378I don't think yargs lets you alias something as
--no-some-optiononly as--some-option, but this isn't really an issue in our case, see Alias single letter to negated boolean option yargs/yargs-parser#406