Cleanup of Features management #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating from base repo
| @@ -1,278 +1,278 @@ | |||
| package cucumber.runtime.arquillian.client; | |||
There was a problem hiding this comment.
this diff shouldnt be on the whole file
There was a problem hiding this comment.
I agree, not sure why it shows it that way
There was a problem hiding this comment.
Could be the distance of the changes: line 11, line 64, line 225 and line 276
private class FeatureSearchData
|
I returned the test to its previous state and reduced the number of private methods by one level. I also added a helper class to handle the urlPath, urlSuffix, featureHome, etc. that kept being passed between methods, this way I reduced the list of params in some functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed cucumber.runtime.arquillian.feature.Features class name to FeaturesManager;
broke createFeatureMap method into smaller private methods and rearranged the content of the class;
changed the accesors of the other public methods as they are not called anywhere outside of the FeaturesManager (nor do they seem like they should be)
*: I don't really get the whole findWithCucumberSearcher name, as far as I see it you're loading a resource from where you load the URLs of the features, so I kept the CucumberSearcher part in the extractUrlMap and createList method but I don't really get it.
**: I ran all the tests and everything seems fine this time