Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pre-commit-hooks: Added pre-commit-hooks #2883

Closed
wants to merge 2 commits into from

Conversation

gauthsvenkat
Copy link

This commit adds a pre-commit-hook for common cue (sub) commands

At the moment, only cue vet and cue fmt are included.

Fixes #2834

This commit adds a pre-commit-hook for common cue (sub) commands

At the moment, only `cue vet` and `cue fmt` are included.

Fixes #2834

Signed-off-by: Gautham <gauthsvenkat@gmail.com>
@gauthsvenkat
Copy link
Author

This is by no means a complete pull request. I need advice on 2 things.

  1. What are sensible defaults for the hooks?
  2. Which cue commands make sense to be included in the pre-commit hook? For eg. cue export would be a good candidate.
    And of course, what are the sensible defaults for those commands?

Furthermore, I also plan on adding the option to use the docker version of cue with pre-commit.

@gauthsvenkat gauthsvenkat marked this pull request as draft February 28, 2024 18:59
@gauthsvenkat
Copy link
Author

Closing PR along with #2834 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project: pre-commit hooks
1 participant