internal/cmd/cue-ast-print: fix panic when printing the ast tree #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panic was observed when running cue-ast-print 2567.slice.1.cue or similar cue samples.
This commit fixes the problem by moving the test `if !v.IsValid(){...}` a few lines up,
to prevent referencing a nil pointer.
The script issue-panic.txtar verifies that cue-ast-print works after this fix.
Running the script with a build of cue-ast-print before the fix demonstrates the panic
about half-way into the printing.
Signed-off-by: Rudi Farkas <rudi.farkas@gmail.com>
|
Thanks! Importing as https://review.gerrithub.io/c/cue-lang/cue/+/1194721. |
cueckoo
pushed a commit
that referenced
this pull request
May 14, 2024
For example, in SliceExpr, the High field can be a nil interface, and that caused us to panic as reflect.Value.Elem returns a zero Value in such a scenario. Thanks to Rudolf Farkas for the report and fix. Note that we don't have any tests right now, as this tool is used only for debugging purposes. Closes #2771 as merged. Signed-off-by: Daniel Martí <mvdan@mvdan.cc> Change-Id: Id41797ea500b75bbc7a09f7f40cc9e51f5c0931a
|
Happy to help!
Le mar. 14 mai 2024 à 17:23, Daniel Martí ***@***.***> a
écrit :
… Thanks! Importing as https://review.gerrithub.io/c/cue-lang/cue/+/1194721.
—
Reply to this email directly, view it on GitHub
<#2771 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKC5D6AY2FWUST3VMO2NTZCIT53AVCNFSM6AAAAABCDO3TK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGUZDANZXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic was observed when running cue-ast-print 2567.slice.1.cue or similar cue samples.
This commit fixes the problem by moving the test
if !v.IsValid(){...}a few lines up, to prevent referencing a nil pointer.The script issue-panic.txtar verifies that cue-ast-print works after this fix.
Running the script with a build of cue-ast-print before the fix demonstrates the panic about half-way into the printing.