Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure due to bumped dependencies in macos-latest GitHub runner #117

Merged
merged 1 commit into from Mar 18, 2024

Conversation

kieran-ryan
Copy link
Sponsor Member

@kieran-ryan kieran-ryan commented Mar 18, 2024

🤔 What's changed?

Bumped node-gyp to 10.0.1.

⚡️ What's your motivation?

All pipelines are presently failing and blocked due to failing jobs on the macos-latest runner - which bumped its Python version to 3.12 and is incompatible with our version of node-gyp. Bumping the dependency resolves the issue and has been applied to cucumber/language-service#175.

Fix Python 3.12 incompatibility with the macos-latest runner

Following macOS 12 (20231029) release of the macos-latest GitHub runner, the Python distribution changed to 3.12 - this is incompatible with the version of node-gyp used to compile the tree-sitter language bindings. Specifically, our pinned version uses the distutils module which is removed from the standard library 3.12 - which has been discussed on other issues (cucumber/gherkin#40). Our pipelines have failed since this release.

The tree-sitter language binding dependencies were previously made optional to support Windows runners (#58) - suppressing the failure as the logs are less verbose. More information on the failure can be revealed by increasing the log verbosity (-ddd) and by making the dependency required.

As such, the issue is resolved by either pinning Python to 3.9 or updating node-gyp to >= v10 - which is compatible with 3.12. The latter has been chosen, as we will need to bump the version in future in any case.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Mar 18, 2024
@kieran-ryan kieran-ryan self-assigned this Mar 18, 2024
@kieran-ryan kieran-ryan merged commit 77c96b5 into main Mar 18, 2024
2 checks passed
@kieran-ryan kieran-ryan deleted the bump-node-gyp branch March 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant