Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatters): junit formatter template methods for creating elements #2349

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinlacotaco
Copy link

🤔 What's changed?

Creates functions that can be overridden within the junit formatter to help create elements within the XML with more flexibility. Uses the object creation of the xmlbuilder to not allow complete control of root elements among others.

Conversion from object are discussed: https://github.com/oozcitak/xmlbuilder-js/wiki/Conversion-From-Object

⚡️ What's your motivation?

Fixes #2348

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

coverage: 97.836% (+0.003%) from 97.833%
when pulling 44af7a5 on kevinlacotaco:feat/junit-specific-nodes
into 6eede88 on cucumber:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit XML Extension failure message/stack separation (custom test case element generators)
2 participants