Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: loadSources function #1957

Merged
merged 12 commits into from Mar 21, 2022
Merged

api: loadSources function #1957

merged 12 commits into from Mar 21, 2022

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

  • Add a loadSources function to the new API that does the Gherkin work and returns arrays of filtered, ordered pickles and parse errors
  • Refactor runCucumber internals to use the same underpinning code
  • Revert changes to parseGherkinMessageStream so there are no breaking changes there - it's now a standalone function that we can remove in a future major release (it's on the main entry point and is used by some third party code) once people have had time to switch over

⚡️ What's your motivation?

By popular demand via #1711.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, docuemntation etc. without changing behaviour)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@coveralls
Copy link

coveralls commented Mar 18, 2022

Coverage Status

Coverage decreased (-0.06%) to 98.217% when pulling a808901 on feat/load-sources into 6feaefb on main.

@davidjgoss davidjgoss marked this pull request as ready for review March 18, 2022 15:39
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the question, looks good 👌

src/cli/helpers.ts Show resolved Hide resolved
@davidjgoss davidjgoss merged commit ad1d112 into main Mar 21, 2022
@davidjgoss davidjgoss deleted the feat/load-sources branch March 21, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants