Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass pattern to definitionFunctionWrapper #1121

Closed
wants to merge 1 commit into from
Closed

pass pattern to definitionFunctionWrapper #1121

wants to merge 1 commit into from

Conversation

Logout22
Copy link

required to get access to the step's definition pattern
when writing a BeforeStep / AfterStep hook as mentioned in #997

comments / feedback welcome :)

required to get access to the step's definition pattern
when writing a BeforeStep / AfterStep hook as mentioned in #997
@Logout22
Copy link
Author

Does the pull request need more explanations? Should I add an acceptance test illustrating what the change could be used for? Thanks!

@charlierudolph
Copy link
Member

Why does a beforeStep / afterStep need the step pattern?

@SebastienGllmt
Copy link

@charlierudolph in my case I would like to wrap any step that starts with "I should see" to take a screenshot after it's done.
However if there is a different fix planned for #1058 then maybe this is not required.

@Logout22
Copy link
Author

@charlierudolph For logging, you generally want to know what step you are operating on, right? The only way to identify steps that I know is the step pattern, but I am open to suggestions here.

@charlierudolph
Copy link
Member

Going to close as I want to deprecate wrapDefinitions as it was generators and its not needed anymore. I'd rather have normal beforeStep / afterStep for this. Will work on getting that merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants